[webkit-reviews] review granted: [Bug 10129] REGRESSION: webViewDidChange: posted even when should* delegates reply NO : [Attachment 9974] DumpRenderTree patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Aug 12 18:03:27 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10129: REGRESSION: webViewDidChange: posted even when should* delegates
reply NO
http://bugzilla.opendarwin.org/show_bug.cgi?id=10129

Attachment 9974: DumpRenderTree patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9974&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks OK.

Formatting of this:

+	 if(acceptsEditing) {

does not match our standard, and there is code here with braces around
single-line blocks that also does not match it.

r=me



More information about the webkit-reviews mailing list