[webkit-reviews] review granted: [Bug 8980] ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc]) : [Attachment 9658] Don't leave the package loaded on return from -pListForPath:createFile: if it wasn't loaded on entry

[bugzilla-request-daemon at opendarwin.org]

Tim Omernick <timo at apple.com> has granted Tim Omernick <timo at apple.com>'s
request for review:
Bug 8980: ASSERTION FAILED: !isLoaded
(WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage
dealloc])
http://bugzilla.opendarwin.org/show_bug.cgi?id=8980

Attachment 9658: Don't leave the package loaded on return from
-pListForPath:createFile: if it wasn't loaded on entry
http://bugzilla.opendarwin.org/attachment.cgi?id=9658&action=edit

------- Additional Comments from Tim Omernick <timo at apple.com>
I changed my mind about this patch.  I think this is actually a reasonable fix.
 I was initially concerned about the efficiency of loading/unloading the
package inside of this method, esp. where the package will eventually be used
(and will therefore need to be loaded again).

However, looking at the patch again, I see that this is only an issue when the
plug-in has an external MIME type registration plist.

I am going to test this patch a bit and then land it.