[webkit-reviews] review granted: [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation) : [Attachment 9964] Fix for case-insensitive lookup

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Aug 10 16:55:59 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10230: SVGDOMImplementation should die (and be rolled into

Attachment 9964: Fix for case-insensitive lookup

------- Additional Comments from Darin Adler <darin at apple.com>
This looks fine. But there are more-efficient alternatives:

For example, you could make this:

    static void addString(HashSet<StringImpl*, CaseInsensitiveHash>& set, const
char* string)
	StringImpl* s = new StringImpl(string);
	add(set, s);

Then you wouldn't need local variables at all:

    #define SVGFEATURE(feature) addString(svgFeatures, #feature);

And in fact, invoking this is simple enough that you don't even need to use a
macro! And you don't need SVGFEATURE2.
Also, isSVG10Feature and isSVG11Feature should both be marked static.

Feel free to land what you have, or please post a new patch based on my

More information about the webkit-reviews mailing list