[webkit-reviews] review requested: [Bug 10335] [S60] browser crashes when exit : [Attachment 9970] Files: BrCtl.cpp

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Aug 10 12:05:28 PDT 2006

Joseph Ligman <joseph.ligman at nokia.com> has asked Yongjun Zhang
<yongjun.zhang at nokia.com> for review:
Bug 10335: [S60] browser crashes when exit

Attachment 9970: Files: BrCtl.cpp

------- Additional Comments from Joseph Ligman <joseph.ligman at nokia.com>
Browser crashes on exit because ~CPluginSkin trys to make use of the
iBrCtlSoftkeysObserver in it's destructor. The iBrCtlSoftkeysObserver is not
always owned by CBrCtl and therefore could be deleted prematurely. When the
CPluginSkin tried to make use of it, it was no longer valid and it was not set
to NULL. To resolve this the object destruction was rearranged in CBrCtl to
delete the CWebKitControl after deleting all of the observers and setting them
to NULL.

More information about the webkit-reviews mailing list