[webkit-reviews] review granted: [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation) : [Attachment 9912] Improved patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10230: SVGDOMImplementation should die (and be rolled into
DOMImplementation)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10230

Attachment 9912: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9912&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Ideally, I'd like to see the test cover some poorly-formed feature strings too,
and test the case insensitivity more directly. It's good as-is, but could be
even better.

+#if SVG_SUPPORT

Should use #ifdef SVG_SUPPORT as in the upcoming patch to fix compilation
without SVG while using -Wundef.

You don't really need the initialized boolean. Can just check is the HashSet is
empty using isEmpty.

But those are nitpicks, this looks fine now.

r=me