[webkit-reviews] review requested: [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation) : [Attachment 9912] Improved patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Aug 7 02:28:40 PDT 2006


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 10230: SVGDOMImplementation should die (and be rolled into
DOMImplementation)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10230

Attachment 9912: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9912&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
With the new patch I hope to address these problems with the old code:
- whole hash table was leaked before
- 1.0 and 1.1 feature were mixed, so a substring from 1.1 could be appended to
the 1.0 prefix, for example org.w3c.Script. Now I use two seperate hash tables,
no mixing possible.
Cheers,

Rob.



More information about the webkit-reviews mailing list