[webkit-reviews] review granted: [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation) : [Attachment 9894] Now with testcase

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10230: SVGDOMImplementation should die (and be rolled into
DOMImplementation)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10230

Attachment 9894: Now with testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=9894&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This looks fabulous.

two comments:

1. this comment is backwards:
+// TODO: features need to be commented out when we implement them

things should be "uncommented" once we implement them.

also I would probably have used FALSE and true or some more-easily
distinguisable pair of vaues in the test case.

Looks great!
r=me.