[webkit-reviews] review denied: [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation) : [Attachment 9871] improved patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10230: SVGDOMImplementation should die (and be rolled into
DOMImplementation)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10230

Attachment 9871: improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9871&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Yes, Eric is right.

I suggest that svgFeatureSet be HashSet<String, CaseInsensitiveHash>. You
should not need to call lower or upper at all.

The patch looks good -- but I think it would be better to use a
case-insensitive hash.