[webkit-reviews] review cancelled: [Bug 10192] Make WebCore (and friends) compile with -Wshorten-64-to-32 : [Attachment 9837] patch of remaining less trivial changes

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Aug 3 19:36:34 PDT 2006


Darin Adler <darin at apple.com> has cancelled Sam Weinig <sam.weinig at gmail.com>'s
request for review:
Bug 10192: Make WebCore (and friends) compile with -Wshorten-64-to-32
http://bugzilla.opendarwin.org/show_bug.cgi?id=10192

Attachment 9837: patch of remaining less trivial changes
http://bugzilla.opendarwin.org/attachment.cgi?id=9837&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Clearing the review flag on this for now. We should go over the other cases in
WebKit and see what we can do for each one. Either there's some reason we can
guarantee the value fits in 32 bits or we need some checks and error handling.



More information about the webkit-reviews mailing list