[webkit-reviews] review denied: [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation) : [Attachment 9856] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Aug 3 13:49:48 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10230: SVGDOMImplementation should die (and be rolled into

Attachment 9856: First attempt

------- Additional Comments from Darin Adler <darin at apple.com>
Instead of upper.startsWith("HTTP://WWW.W3.ORG/TR/SVG11/FEATURE#") I'd like to
see feature.startsWith(xxx, false).

The svgFeatureSet set should be a case insensitive set intsead of being a case
sensitive HashSet.

But if we're going to use all uppercase it should not include "dom.svg.ALL" in
mixed case!

I'd prefer not to use "upper()" at all.

Also, don't use braces around single lines in this code:

+    if (namespaceURI == SVGNames::svgNamespaceURI) {
+	 doc = new SVGDocument(this, 0);
+    }

More information about the webkit-reviews mailing list