[webkit-reviews] review denied: [Bug 10216] PDF created by printing should have live hyperlinks : [Attachment 9841] patch fix for this bug.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Aug 2 17:27:08 PDT 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 10216: PDF created by printing should have live hyperlinks

Attachment 9841: patch fix for this bug.

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Ok, here are my comments.

(1) This feature as coded will cause a slowdown.  We will need a way to only do
work when we detect that we're drawing into a PDF context.

(2) You need to deal with partial clipping (unless the CG API does this for

(3) Patching only InlineFlowBox is insufficient and won't give you the right
rects.	This won't work for image links.  It won't work when the link is a
block.	It won't work if the content inside the link is a larger font size.

I would probably limit this feature to images and text and patch those methods

More information about the webkit-reviews mailing list