[webkit-reviews] review requested: [Bug 10192] Make WebCore (and friends) compile with -Wshorten-64-to-32 : [Attachment 9837] patch of remaining less trivial changes

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Aug 2 15:20:10 PDT 2006


Sam Weinig <sam.weinig at gmail.com> has asked  for review:
Bug 10192: Make WebCore (and friends) compile with -Wshorten-64-to-32
http://bugzilla.opendarwin.org/show_bug.cgi?id=10192

Attachment 9837: patch of remaining less trivial changes
http://bugzilla.opendarwin.org/attachment.cgi?id=9837&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
This third patch contains the remaining changes.  NOTE: none of the changes in
this patch change any behavior, they simply explicitly down cast 64 bit types
to 32 bit types that would be implicitly down cast anyway.  The question is if
those implicit conversions were safe to begin with and if not how we should
deal with them.



More information about the webkit-reviews mailing list