[webkit-reviews] review requested: [Bug 10192] Make WebCore (and friends) compile with -Wshorten-64-to-32 : [Attachment 9834] patch of trivial changes

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Aug 2 14:51:26 PDT 2006


Sam Weinig <sam.weinig at gmail.com> has asked  for review:
Bug 10192: Make WebCore (and friends) compile with -Wshorten-64-to-32
http://bugzilla.opendarwin.org/show_bug.cgi?id=10192

Attachment 9834: patch of trivial changes
http://bugzilla.opendarwin.org/attachment.cgi?id=9834&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
This patch includes only the trivial changes needed to compile with
-Wshorten-64-to-32.  The changes include adding 'f's to the end of float
literals and switching some cos()'s and ceil()'s to cosf()'s and ceilf()'s. 
I've also added the flag to the Xcode project for JaveScriptGlue as it needs no
modifications to compile with it.



More information about the webkit-reviews mailing list