[webkit-reviews] review requested: [Bug 10176] Make WebCore compile with -Wundef : [Attachment 9829] patch 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Aug 2 11:53:39 PDT 2006


Sam Weinig <sam.weinig at gmail.com> has asked  for review:
Bug 10176: Make WebCore compile with -Wundef
http://bugzilla.opendarwin.org/show_bug.cgi?id=10176

Attachment 9829: patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=9829&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
This version fixes the SPEED_DEBUG issue and converts the #ifdef WIN32's from
WebCore to #if PLATFORM(WIN_OS) and PLATFORM(WIN) (and in one case in config.h
to #if !COMPILER(MSVC)).  Some of my choices between WIN_OS and WIN might very
well be wrong because I am not entirely familiar with the WIN32 platform.



More information about the webkit-reviews mailing list