[webkit-reviews] review requested: [Bug 10192] Make WebCore (and friends) compile with -Wshorten-64-to-32 : [Attachment 9802] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Aug 1 14:34:00 PDT 2006


Sam Weinig <sam.weinig at gmail.com> has asked  for review:
Bug 10192: Make WebCore (and friends) compile with -Wshorten-64-to-32
http://bugzilla.opendarwin.org/show_bug.cgi?id=10192

Attachment 9802: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9802&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
Attaching patch with ChangeLogs.  All of the changes to the code are making
explicit, already implicit conversions/casts from 64 bit types (such as double
or long long) to 32 bit types.	Some of these conversions are worrisome as data
is potentially being lost.



More information about the webkit-reviews mailing list