[webkit-reviews] review:?
Andrea Mannori
andrea.mannori at gmail.com
Fri Apr 28 10:11:23 PDT 2006
Hi,
I' ve just "patched" the file pcre_compile.c for not having the
warning (the variablee) "may be used uninitialized in this function"
-------------- next part --------------
Index: JavaScriptCore/pcre/pcre_compile.c
===================================================================
--- JavaScriptCore/pcre/pcre_compile.c (revision 14101)
+++ JavaScriptCore/pcre/pcre_compile.c (working copy)
@@ -3311,7 +3311,7 @@ for (;; ptr++)
#ifdef SUPPORT_UCP
else if (-c == ESC_P || -c == ESC_p)
{
- BOOL negated;
+ BOOL negated=TRUE ;
int value = get_ucp(&ptr, &negated, errorcodeptr);
previous = code;
*code++ = ((-c == ESC_p) != negated)? OP_PROP : OP_NOTPROP;
@@ -4003,10 +4003,10 @@ pattern. We can't be so clever for #-com
ptr = (const pcre_uchar *)(pattern - 1);
while ((c = *(++ptr)) != 0)
{
- int min, max;
- int class_optcount;
- int bracket_length;
- int duplength;
+ int min=0, max=0;
+ int class_optcount=0;
+ int bracket_length=0;
+ int duplength=0;
/* If we are inside a \Q...\E sequence, all chars are literal */
Index: JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
===================================================================
--- JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (revision 14101)
+++ JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (working copy)
@@ -421,7 +421,7 @@
933A349D038AE80F008635CE /* identifier.cpp */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.cpp.cpp; path = identifier.cpp; sourceTree = "<group>"; tabWidth = 8; };
935AF46909E9D9DB00ACD1D8 /* Forward.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Forward.h; sourceTree = "<group>"; };
935AF46B09E9D9DB00ACD1D8 /* UnusedParam.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UnusedParam.h; sourceTree = "<group>"; };
- 935F69F608244FEA003D1A45 /* dftables */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = dftables; sourceTree = BUILT_PRODUCTS_DIR; };
+ 935F69F608244FEA003D1A45 /* dftables */ = {isa = PBXFileReference; includeInIndex = 0; lastKnownFileType = "compiled.mach-o.executable"; path = dftables; sourceTree = BUILT_PRODUCTS_DIR; };
9364B273045B7D6C00A9CAC1 /* fpconst.cpp */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.cpp.cpp; path = fpconst.cpp; sourceTree = "<group>"; tabWidth = 8; };
9373524E038DA8C2008635CE /* context.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = context.h; sourceTree = "<group>"; tabWidth = 8; };
9374D3A7038D9D74008635CE /* scope_chain.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = scope_chain.h; sourceTree = "<group>"; tabWidth = 8; };
@@ -1463,6 +1463,8 @@
149C277208902AFE008A9EFC /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ GCC_ALTIVEC_EXTENSIONS = YES;
+ GCC_AUTO_VECTORIZATION = YES;
GCC_ENABLE_CPP_EXCEPTIONS = NO;
GCC_ENABLE_CPP_RTTI = NO;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
@@ -1470,15 +1472,17 @@
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
GCC_INLINES_ARE_PRIVATE_EXTERN = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_STRICT_ALIASING = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+ GCC_UNROLL_LOOPS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
WARNING_CFLAGS = (
@@ -1500,6 +1504,8 @@
149C277308902AFE008A9EFC /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ GCC_ALTIVEC_EXTENSIONS = YES;
+ GCC_AUTO_VECTORIZATION = YES;
GCC_ENABLE_CPP_EXCEPTIONS = NO;
GCC_ENABLE_CPP_RTTI = NO;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
@@ -1507,15 +1513,17 @@
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
GCC_INLINES_ARE_PRIVATE_EXTERN = YES;
- GCC_MODEL_TUNING = G5;
- GCC_OPTIMIZATION_LEVEL = 2;
+ GCC_MODEL_TUNING = G4;
+ GCC_OPTIMIZATION_LEVEL = 3;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_STRICT_ALIASING = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+ GCC_UNROLL_LOOPS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
WARNING_CFLAGS = (
@@ -1537,6 +1545,8 @@
149C277508902AFE008A9EFC /* Production */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ GCC_ALTIVEC_EXTENSIONS = YES;
+ GCC_AUTO_VECTORIZATION = YES;
GCC_ENABLE_CPP_EXCEPTIONS = NO;
GCC_ENABLE_CPP_RTTI = NO;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
@@ -1544,14 +1554,16 @@
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = NO;
GCC_INLINES_ARE_PRIVATE_EXTERN = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 2;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_STRICT_ALIASING = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+ GCC_UNROLL_LOOPS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+ OTHER_CFLAGS = "-mcpu=G4";
WARNING_CFLAGS = (
"-Wall",
"-W",
Index: JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj
===================================================================
--- JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj (revision 14101)
+++ JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj (working copy)
@@ -483,20 +483,24 @@
14AC662C08CE7791006915A8 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ GCC_ALTIVEC_EXTENSIONS = YES;
+ GCC_AUTO_VECTORIZATION = YES;
GCC_ENABLE_CPP_EXCEPTIONS = NO;
GCC_ENABLE_CPP_RTTI = NO;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+ GCC_UNROLL_LOOPS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
WARNING_CFLAGS = (
@@ -518,20 +522,24 @@
14AC662D08CE7791006915A8 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ GCC_ALTIVEC_EXTENSIONS = YES;
+ GCC_AUTO_VECTORIZATION = YES;
GCC_ENABLE_CPP_EXCEPTIONS = NO;
GCC_ENABLE_CPP_RTTI = NO;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 2;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+ GCC_UNROLL_LOOPS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
WARNING_CFLAGS = (
@@ -553,19 +561,24 @@
14AC662E08CE7791006915A8 /* Production */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ GCC_ALTIVEC_EXTENSIONS = YES;
+ GCC_AUTO_VECTORIZATION = YES;
GCC_ENABLE_CPP_EXCEPTIONS = NO;
GCC_ENABLE_CPP_RTTI = NO;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = NO;
- GCC_MODEL_TUNING = G5;
- GCC_OPTIMIZATION_LEVEL = 2;
+ GCC_MODEL_TUNING = G4;
+ GCC_OPTIMIZATION_LEVEL = 3;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
+ GCC_STRICT_ALIASING = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
+ GCC_UNROLL_LOOPS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+ OTHER_CFLAGS = "-mcpu=G4";
WARNING_CFLAGS = (
"-Wall",
"-W",
Index: WebKit/WebKit.xcodeproj/project.pbxproj
===================================================================
--- WebKit/WebKit.xcodeproj/project.pbxproj (revision 14101)
+++ WebKit/WebKit.xcodeproj/project.pbxproj (working copy)
@@ -2031,7 +2031,7 @@
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
@@ -2039,6 +2039,7 @@
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PER_CONFIGURATION_PREPROCESSOR_DEFINES = "ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
@@ -2070,7 +2071,7 @@
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 2;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
@@ -2078,6 +2079,7 @@
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PER_CONFIGURATION_PREPROCESSOR_DEFINES = "ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
@@ -2109,13 +2111,14 @@
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = NO;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 2;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+ OTHER_CFLAGS = "-mcpu=G4";
WARNING_CFLAGS = (
"-Wall",
"-W",
Index: WebCore/WebCore.xcodeproj/project.pbxproj
===================================================================
--- WebCore/WebCore.xcodeproj/project.pbxproj (revision 14101)
+++ WebCore/WebCore.xcodeproj/project.pbxproj (working copy)
@@ -5675,7 +5675,7 @@
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
@@ -5683,6 +5683,7 @@
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
WARNING_CFLAGS = (
@@ -5710,7 +5711,7 @@
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 2;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
@@ -5718,6 +5719,7 @@
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
MACOSX_DEPLOYMENT_TARGET = 10.4;
+ OTHER_CFLAGS = "-mcpu=G4";
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
WARNING_CFLAGS = (
@@ -5745,13 +5747,14 @@
GCC_ENABLE_OBJC_GC = YES;
GCC_FAST_OBJC_DISPATCH = YES;
GCC_GENERATE_DEBUGGING_SYMBOLS = NO;
- GCC_MODEL_TUNING = G5;
+ GCC_MODEL_TUNING = G4;
GCC_OPTIMIZATION_LEVEL = 2;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+ OTHER_CFLAGS = "-mcpu=G4";
WARNING_CFLAGS = (
"-Wall",
"-W",
-------------- next part --------------
hope is helpfull
best reguards
Andrea Mannori
More information about the webkit-reviews
mailing list