[webkit-reviews] review denied: [Bug 8528] Bakefiles (and generated Makefiles) for wx and gdk ports : [Attachment 7934] Renamed GNU makefiles to GNUmakefile and integrated GDK port updates.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Apr 27 07:41:04 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8528: Bakefiles (and generated Makefiles) for wx and gdk ports

Attachment 7934: Renamed GNU makefiles to GNUmakefile and integrated GDK port

------- Additional Comments from Darin Adler <darin at apple.com>
(In reply to comment #17)
> I was just concerned that some people who are used to checkout -> build would

> not like the process to become checkout -> generate projects -> build. (e.g.
> we ever moved the VC2005 projects over to using this system) The other
> to create generated files are run automatically via the project files, but
> obviously we can't do that for the generation of the project files
> which means we add a manual step which would have to be run after each
> But at the same time, I see the logic for not keeping generated files in SVN,

> so I'm open to doing it either way.
> If you want, I can go ahead and remove those generated files from the patch.

Yes, I'd like to see this done without checking in the generated files.

People who want to just be able to check out and build can use a build script
of some sort, and we can automate the checking at least as suggested by Vaclav
Slavik -- for some build systems it can be entirely automatic, for the others
it can at least be an error that is detected. Over time we may find ways to
automate even for things like Microsoft Visual Studio projects.

> > It seems strange to have the bakefiles in a Bakefiles directory instead of
> > inside the individual project directories.
> The main issue is that several of those Bakefiles are shared between WebCore
> ports, and presets.bkl is shared between JavaScriptCore and WebCore, so
> up with 'appropriate' placement of shared items seemed more involved than
> having one directory for all the Bakefiles. Of course, that could just be my
> organization style. :-) Did you want me to move the files into various
> directories? If so, do you have any suggestions as to where would be a good
> location for the presets.bkl and readme.txt files? 

The files that list all the things in a project should be inside that project.
For example, if there's a list of all the files in WebCore, it's very important
that's inside the WebCore directory.

If there are shared things, it's fine for them to be in a shared place, but
anything that has to change as a particular project changes should be in that
project if possible.

Could you take another pass at this given those comments?

More information about the webkit-reviews mailing list