[webkit-reviews] review requested: [Bug 8614] REGRESSION (r14048):
Google calendar not parsing : [Attachment 7986] Preliminary
patch -- no test case
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Apr 26 14:33:12 PDT 2006
Geoffrey Garen <ggaren at apple.com> has asked for review:
Bug 8614: REGRESSION (r14048): Google calendar not parsing
http://bugzilla.opendarwin.org/show_bug.cgi?id=8614
Attachment 7986: Preliminary patch -- no test case
http://bugzilla.opendarwin.org/attachment.cgi?id=7986&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Posting here for Eric since he wrote the original patch.
I'm not sure we needed the grandparent check to begin with -- we pass the test
without it. Eric, can we just remove it entirely? Do you have a testcase where
we crash with a NULL grandparent?
This patch preserves the grandparent check but localizes it to code paths that
require it.
More information about the webkit-reviews
mailing list