[webkit-reviews] review granted: [Bug 5860] feComponentTransfer doesn't work : [Attachment 7955] This should sooo be the final patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Apr 25 08:08:59 PDT 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5860: feComponentTransfer doesn't work

Attachment 7955: This should sooo be the final patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
In general this looks great.

A couple comments:
1. There is no real need for the identity filter to do anything.  No need to
copy the bytes, just return the original image from a noop apply call.
2. The interpolation bug you mention should have a radar filed about it (even
if you're not sure it's a bug) and then that radar number should be added to
the comment.

All and all, this is landable as is.  It would be nice to fix those two issues,
although those aren't show-stoppers.

More information about the webkit-reviews mailing list