[webkit-reviews] review requested: [Bug 8563] [DOMHTMLDocument doctype] always returning nil. : [Attachment 7940] Patch for this bug

[bugzilla-request-daemon at opendarwin.org]

Matt Gough <matt at softchaos.com> has asked  for review:
Bug 8563: [DOMHTMLDocument doctype] always returning nil.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8563

Attachment 7940: Patch for this bug
http://bugzilla.opendarwin.org/attachment.cgi?id=7940&action=edit

------- Additional Comments from Matt Gough <matt at softchaos.com>
This patch:
1. Removes DocumentType *HTMLDocument::doctype() const from HTMLDocument.h and
cpp.
2. Changes the comment in Document.h to say that docType() may return 0.
3. Changes LayoutTests/dom/html/level1/core/hc_documentgetdoctype.js to do a
case insensitive compare of docTypeName against 'html' (Since HTML is the name
specified in HTMLDocument::determineParseMode when creating the docType for
HTML.) Not sure whether this is the correct approach, or to just make
HTMLDocument::determineParseMode use 'html'