[webkit-reviews] review granted: [Bug 8541] finish autogeneration of Element interface : [Attachment 7913] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Apr 22 14:43:26 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8541: finish autogeneration of Element interface

Attachment 7913: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
I'm a bit concerned about the larger and larger quantity of C++ code that's in
CodeGeneratorJS.pm. We should find a better way to arrange things so the code
doesn't have to be inside multiple lines of push statements and quotation
marks, probably using "HERE documents".

It also seems that the JavaScript-visible names of these classes should not
include the "JS" prefix. It should be [object Element] rather than [object

But, still, r=me.

More information about the webkit-reviews mailing list