[webkit-reviews] review denied: [Bug 8531] Added new Platform macros and using them for porting : [Attachment 7901] Additional Cairo and Gdk platform def

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Apr 22 14:34:42 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8531: Added new Platform macros and using them for porting
http://bugzilla.opendarwin.org/show_bug.cgi?id=8531

Attachment 7901: Additional Cairo and Gdk platform def
http://bugzilla.opendarwin.org/attachment.cgi?id=7901&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This is wrong. We need to set KXMLCORE_PLATFORM_CAIRO for Win32 builds too, if
it's going to exist. Also, graphics platform settings should go in a different
section, not mixed in with MAC and WIN.



More information about the webkit-reviews mailing list