[webkit-reviews] review denied: [Bug 8531] Added new Platform macros and using them for porting : [Attachment 7902] Patch using CAIRO PLATFORM

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Apr 22 14:33:42 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8531: Added new Platform macros and using them for porting
http://bugzilla.opendarwin.org/show_bug.cgi?id=8531

Attachment 7902: Patch using CAIRO PLATFORM
http://bugzilla.opendarwin.org/attachment.cgi?id=7902&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
There should never be a need to say "PLATFORM(CAIRO) || PLATFORM(WIN32)", so
this is not correct. It should just be PLATFORM(CAIRO) and we should make sure
it's set when building for Win32.



More information about the webkit-reviews mailing list