[webkit-reviews] review denied: [Bug 8507] Compilation fixes for building on gcc 4.0.2, and without precomp headers : [Attachment 7865] Patch for compilation fixes.

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8507: Compilation fixes for building on gcc 4.0.2, and without precomp
headers
http://bugzilla.opendarwin.org/show_bug.cgi?id=8507

Attachment 7865: Patch for compilation fixes.
http://bugzilla.opendarwin.org/attachment.cgi?id=7865&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good. I see three problems:

    1) The include for pthread.h should be !PLATFORM(WIN_OS), not
!PLATFORM(WIN)

    2) Assertions.cpp should use <stdio.h>, <stdarg.h>, and <string.h>, not
"stdio.h", etc.

    3) +#elseif defined(__APPLE__)

No such thing as #elseif. It's #elif.

That issue (3) seems serious enough that we should not land it, so r-. But if
you fix those 3 things, then this looks good to go.