[webkit-reviews] review denied: [Bug 8495] REGRESSION: Sidebar on cnn.com is hosed : [Attachment 7863] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Apr 20 22:46:55 PDT 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 8495: REGRESSION: Sidebar on cnn.com is hosed

Attachment 7863: Patch

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
For now I recommend we remove the new NO_REPEAT clause you added.  I think we
need way more tests in the tree to baseline against before we stop calling
drawTiledImage in the NO_REPEAT case.

I noticed scaledWidth and scaledHeight initialized to bogus values earlier in
the code.  You can remove those and just declare scaledWidth/Height right above
your code that sets them to the right values.

There's a bug on the Mac only in tileInRect where oneTileRect is being used to
set the fromRect's size and destination should be used instead.

More information about the webkit-reviews mailing list