[webkit-reviews] review denied: [Bug 7555] :hover style not applied on hover if its display property is different from original style's : [Attachment 7189] Naive patch

[bugzilla-request-daemon at opendarwin.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 7555: :hover style not applied on hover if its display property is
different from original style's
http://bugzilla.opendarwin.org/show_bug.cgi?id=7555

Attachment 7189: Naive patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7189&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I'm not convinced that this new code deals correctly with :active.

When the mouse goes down you put a whole chain of elements into the :active
state.	That chain is then frozen and considered special, since all of the
elements in that chain are the only ones that are allowed to be in :active as
long as the mouse remains down.

However they can leave the :active state.  As the user moves the mouse (with
the button still down) outside of elements in that chain, they have to leave
the :active state.

If the user moves the mouse back into an element in the chain it has to go back
into :active.

A classic example of this is form controls.  Hold your mouse down on a checkbox
and watch how it goes active.  Then move the mouse (with the button still held
down) outside of the checkbox and watch it pop out of :active.	Then move the
mouse back in and it will return to being :active.  The current code deals with
this situation correctly all the way up the :active hierarchy.

You'll need to test the new code to make sure it does.	I would really rather
leave this code in RenderLayer, though, if possible, since it is "XBL-ready".