[webkit-reviews] review requested: [Bug 6635] Crash selecting inspector nodes for tabs that aren't foremost : [Attachment 7846] better patch - skips highlight for elements in hidden tabs

[bugzilla-request-daemon at opendarwin.org]

James G. Speth <speth at end.com> has asked  for review:
Bug 6635: Crash selecting inspector nodes for tabs that aren't foremost
http://bugzilla.opendarwin.org/show_bug.cgi?id=6635

Attachment 7846: better patch - skips highlight for elements in hidden tabs
http://bugzilla.opendarwin.org/attachment.cgi?id=7846&action=edit

------- Additional Comments from James G. Speth <speth at end.com>
use this one.. it's better.  it has the same fix for the loop prevention, plus
checking to make sure the timer is still valid (we invalidate it as part of the
process).  but this patch also has the real solution to why this was happening.
 before doing the highlight, this checks to make sure that the [view window] is
not nil.  if the view is in a hidden tab it will be nil, so this check also
fixes the problem with elements in hidden tabs drawing bad highlights on the
visible tab.