[webkit-reviews] review requested: [Bug 6635] Crash selecting inspector nodes for tabs that aren't foremost : [Attachment 7825] fix for review

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Apr 19 05:37:57 PDT 2006


James G. Speth <speth at end.com> has asked  for review:
Bug 6635: Crash selecting inspector nodes for tabs that aren't foremost
http://bugzilla.opendarwin.org/show_bug.cgi?id=6635

Attachment 7825: fix for review
http://bugzilla.opendarwin.org/attachment.cgi?id=7825&action=edit

------- Additional Comments from James G. Speth <speth at end.com>
added call to remove a NSWindowWillCloseNotification before closing the window,
which avoids the loop that was causing the crash.  actually i'll probably
obsolete this and put in another patch that makes it a bit safer by observing
only this window, not all windows as it was originally.  but this patch works
fine, just in case.



More information about the webkit-reviews mailing list