[webkit-reviews] review requested: [Bug 6427] <tref> element not implemented : [Attachment 7807] Better patch yet

[bugzilla-request-daemon at opendarwin.org]

Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 6427: <tref> element not implemented
http://bugzilla.opendarwin.org/show_bug.cgi?id=6427

Attachment 7807: Better patch yet
http://bugzilla.opendarwin.org/attachment.cgi?id=7807&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
This patch should fix the problem with using attach(). I think since
handling of attributes is not guarenteed, we need to check for
the referenced text both in attributeChanged and parseMappedAttribute.
I chose for a private helper method, I have no idea whether a
non-member(hidden)
method is better, but I'll probably soon know.
Finally the patch lacks testcases, I just commit the patch to find out whether
the
code part is correct now.
Cheers,

Rob.