[webkit-reviews] review denied: [Bug 6427] <tref> element not implemented : [Attachment 7773] Better patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Apr 18 01:47:07 PDT 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6427: <tref> element not implemented

Attachment 7773: Better patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
attach() is still the wrong way to do this.  As this won't handle dynamic
updates.  I think this would be "ok" to land as is, but it's better to just fix
it right the first time.

Also, ideally your patch would contain a diff of the test results you've
changed, including possibly a dynamicly updating test to show that you got href
changes working correctly (which is what my previous attach() complaint is

Other than that, this looks great.  Wonderful work as always Rob.

More information about the webkit-reviews mailing list