[webkit-reviews] review granted: [Bug 8408] Paint the highlight behind selected list markers : [Attachment 7744] Revised patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Apr 16 19:49:30 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8408: Paint the highlight behind selected list markers

Attachment 7744: Revised patch

------- Additional Comments from Darin Adler <darin at apple.com>
In RenderListMarker::selectionRect, I think it's a little strange to compute
selectionRight by adding width() to selectionLeft, then later just subtract
selectionLeft out. Instead we should either just use width() directly or have a
selectionWidth local variable.

Otherwise this looks perfect to me.

r=me with or without that change.

More information about the webkit-reviews mailing list