[webkit-reviews] review granted: [Bug 8417] make-css-file-arrays.pl
hangs when run on Linux : [Attachment 7736] patch for
DerivedSources.make that fixes the hang.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Apr 16 19:26:38 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8417: make-css-file-arrays.pl hangs when run on Linux
http://bugzilla.opendarwin.org/show_bug.cgi?id=8417
Attachment 7736: patch for DerivedSources.make that fixes the hang.
http://bugzilla.opendarwin.org/attachment.cgi?id=7736&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
A few comments:
First, this is not a patch for DerivedSources.make!
Second, patches should include change log comments.
Third, include in RenderArena.cpp should be <assert.h>, not <cassert>, to match
usage in the rest of the project.
But I think all of these are minor and it's good to just land this, so I will
do it as soon as possible.
r=me
More information about the webkit-reviews
mailing list