[webkit-reviews] review granted: [Bug 8389] support for Cocoa bindings - binding an NSTreeController to the WebView's DOM : [Attachment 7720] new patch for review

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Apr 14 21:44:41 PDT 2006


Timothy Hatcher <timothy at hatcher.name> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 8389: support for Cocoa bindings - binding an NSTreeController to the
WebView's DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Attachment 7720: new patch for review
http://bugzilla.opendarwin.org/attachment.cgi?id=7720&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Looks great! Thanks for the code comments.

+    if ([length respondsToSelector:@selector(intValue)])
+	 return [length intValue];
+    else
+	 return 0;

One minor style thing for the future; no need for "else" here.



More information about the webkit-reviews mailing list