[webkit-reviews] review requested: [Bug 6838] Incomplete repaint of collapsed table borders : [Attachment 7701] Patch

[bugzilla-request-daemon at opendarwin.org]

opendarwin.org at mitzpettel.com has asked  for review:
Bug 6838: Incomplete repaint of collapsed table borders
http://bugzilla.opendarwin.org/show_bug.cgi?id=6838

Attachment 7701: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7701&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
This patch implements the updated spec. Some notes:
1. It might be better to cache outerBorderLeft/Right/Top/Bottom in RenderTable
as well.
2. The spec says "CSS 2.1 does not define where the edge of a background on a
table element lies" but I tried to maintain the current behavior. It works with
solid backgrounds but image backgrounds are positioned differently, and I am
not sure how to fix it.
3. The patch causes 43 layout tests to fail. With the exception of pixel
failures due to (2) above, the new layouts look correct to me.
4. Some failures are due to the dump showing "[border: none]" due to the fact
that a table has a non-zero border but its own border-width property is zero.