[webkit-reviews] review granted: [Bug 8333] Blank lines are not properly created when <pre> is used : [Attachment 7696] Patch for review.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Apr 14 00:16:46 PDT 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 8333: Blank lines are not properly created when <pre> is used

Attachment 7696: Patch for review.

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Made some comments over irc.

I suggest you find a way to turn this into an static inline function:

+			 if (!stoppedIgnoringSpaces && pos > 0) {
+			     // We need to stop right before the newline and
then start up again.
+			     BidiIterator midpoint(0, o, pos);
+			     addMidpoint(BidiIterator(0, o, pos-1)); // Stop
+			     addMidpoint(BidiIterator(0, o, pos)); // Start
+			 }

Also, there is no way for me to address the question of whether your test
changes here are sane or not, so I'll just have to trust you there.

You might still want someone else more familiar with this code to review this.

More information about the webkit-reviews mailing list