[webkit-reviews] review granted: [Bug 8363] Greatly reduce macro usage on TreeCode branch, roll "eval()" into interpreter loop : [Attachment 7674] mostly a cleanup patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8363: Greatly reduce macro usage on TreeCode branch, roll "eval()" into
interpreter loop
http://bugzilla.opendarwin.org/show_bug.cgi?id=8363

Attachment 7674: mostly a cleanup patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7674&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I don't think we need s_firstInterpreter, m_nextInterpreter, and
m_prevInterpreter if all the interpreters are in a global map. When we need to
mark all the interpreters we can just iterate the values in the map. For the
count of interpreters we can return size() instead of walking a linked list. I
suggest removing those.

I don't think the state names should include Imp. So it should just be
DeclaredFunctionCallState. In fact, we will remove a lot of those Imp suffixes
some day soon.

I noticed the typo "explicity".

We usually don't use "get" in function names like "getValueReturn()".

Otherwise looks like a fine set of changes (especially if this is not hard to
merge with Maciej's branch).