[webkit-reviews] review requested: [Bug 7877] XMLHttpRequest ignores username/password passed to open() : [Attachment 7602] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Apr 9 11:51:32 PDT 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 7877: XMLHttpRequest ignores username/password passed to open()
http://bugzilla.opendarwin.org/show_bug.cgi?id=7877

Attachment 7602: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=7602&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Hmm, simply unblocking KURL::setUser() and setPass() seems to make things work,
at least when the passed login/password are correct.

Since the desired behavior in the case when login/password are incorrect is not
completely clear (and this is different code anyway), maybe we should
investigate it in a separate step. Currently, sync requests silently fail,
while async ones cause an auth dialog to be displayed, but entering correct
login/password seems to have no effect.



More information about the webkit-reviews mailing list