[webkit-reviews] review granted: [Bug 8264] toLowerCase and toUpperCase don't honor special mappings : [Attachment 7577] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Apr 8 09:53:44 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8264: toLowerCase and toUpperCase don't honor special mappings

Attachment 7577: proposed fix

------- Additional Comments from Darin Adler <darin at apple.com>
I like the general idea here, but it seems a shame to do a malloc in every case
where the result is greater than the source.

It's also a shame that we have to to do the copyForWriting even when the string
is already entirely in the correct case.

I'd have used uint16_t*& for destIfNeeded -- it's not a pointer to a pointer,
it's an in/out parameter that's a pointer, and we normally use references for

But despite those issues, this code looks great and fixes a real problem. I
think we can land it as-is.


More information about the webkit-reviews mailing list