[webkit-reviews] review granted: [Bug 8264] toLowerCase and toUpperCase don't honor special mappings : [Attachment 7577] proposed fix

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8264: toLowerCase and toUpperCase don't honor special mappings
http://bugzilla.opendarwin.org/show_bug.cgi?id=8264

Attachment 7577: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=7577&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I like the general idea here, but it seems a shame to do a malloc in every case
where the result is greater than the source.

It's also a shame that we have to to do the copyForWriting even when the string
is already entirely in the correct case.

I'd have used uint16_t*& for destIfNeeded -- it's not a pointer to a pointer,
it's an in/out parameter that's a pointer, and we normally use references for
those.

But despite those issues, this code looks great and fixes a real problem. I
think we can land it as-is.

r=me