[webkit-reviews] review requested: [Bug 8264] toLowerCase and toUpperCase don't honor special mappings : [Attachment 7577] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Apr 8 08:03:49 PDT 2006

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 8264: toLowerCase and toUpperCase don't honor special mappings

Attachment 7577: proposed fix

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Removed per-character capitalization routines altogether.

Added KXMLCore::Unicode headers to the project.

Looks like at least the ICU implementation should be in a .cpp file, not in the
header - but I left it in the header for now, because the existing inline
functions are even bigger, and maybe there was some reason to put them there.

Changes two Mozilla tests, which were assuming the old behavior.

Three more ICU headers will need to be svn copied to JavaScriptCore, they
didn't show up in the patch.

More information about the webkit-reviews mailing list