[webkit-reviews] review requested: [Bug 8203] REGRESSION: "Invite a friend" text field in GMail page spills out of table : [Attachment 7540] m_minWidth should be 0 for percents

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Apr 6 11:17:00 PDT 2006


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 8203: REGRESSION: "Invite a friend" text field in GMail page spills out of
table
http://bugzilla.opendarwin.org/show_bug.cgi?id=8203

Attachment 7540: m_minWidth should be 0 for percents
http://bugzilla.opendarwin.org/attachment.cgi?id=7540&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is the patch that fixes the test case. RenderReplaced::calcMinMaxWidth()
sets m_minWidth to 0 when the width is a percent, so this patch copies that
behavior into RenderTextField::calcMinMaxWidth(). This causes two layout tests
to have different layout, but Hyatt thinks the new layout is more correct.



More information about the webkit-reviews mailing list