[webkit-reviews] review cancelled: [Bug 7604] calcAbsoluteHorizontalValues() is being getting passed arguments in the wrong order in calcAbsoluteHorizontal() : [Attachment 7194] update patch

[bugzilla-request-daemon at opendarwin.org]

Sam Weinig <sam.weinig at gmail.com> has cancelled Sam Weinig
<sam.weinig at gmail.com>'s request for review:
Bug 7604: calcAbsoluteHorizontalValues() is being getting passed arguments in
the wrong order in calcAbsoluteHorizontal()
http://bugzilla.opendarwin.org/show_bug.cgi?id=7604

Attachment 7194: update patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7194&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
This is a slightly cleaner version of the patch which removes most of the
repeated FIXME's with 3 big FIXME's at the top and makes a few more slight
optimizations such as not calculating for 'right' and 'bottom' when they are
not needed.  It also includes some changes that were made to the current code
regarding the static distance for 'top' when inside a table row.

This patch compiles fine and passes all the layout tests, but is quite a big
patch and therefore I'm woried that some behavior might have changed from the
origanal as many of the corner cases are not tested in the suite.  I agree with
hyatt in that we should try to stick as closely to the origanal behavior as
possible, but I don't really understand what he is proposing in his comment (if
you could elaborate that would be great),