[webkit-reviews] review cancelled: [Bug 8188] Buildbot slaves should upload built frameworks to ease narrowing down regressions : [Attachment 7517] Updated patch

[bugzilla-request-daemon at opendarwin.org]

Mark Rowe (bdash) <opendarwin.org at bdash.net.nz> has cancelled Mark Rowe (bdash)
<opendarwin.org at bdash.net.nz>'s request for review:
Bug 8188: Buildbot slaves should upload built frameworks to ease narrowing down
regressions
http://bugzilla.opendarwin.org/show_bug.cgi?id=8188

Attachment 7517: Updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7517&action=edit

------- Additional Comments from Mark Rowe (bdash)
<opendarwin.org at bdash.net.nz>
A few updates after feedback from Eric on IRC.	getCurrentSVNRevision has moved
into webkitdirs.pm as currentSVNRevision, and it is used in the three locations
where its functionality was duplicated.  In addition, error messages have been
tidied up to provide more information about the failure.

WebKitLauncher/main.m has been updated to stick to Cocoa APIs rather than the
mix of Cocoa and CoreFoundation it was previously.  It should now also meet the
coding style guidelines.