[webkit-reviews] review denied: [Bug 8189] Spinneret nightly builds : [Attachment 7516] Perl script to build nightlies

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Apr 4 20:32:14 PDT 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 8189: Spinneret nightly builds

Attachment 7516: Perl script to build nightlies

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
1. This should be separated out into a "build-spinneret" script.
 2.  We don't generally commit commented out code, so we'll need to fix the
various comment areas.
3.  I don't think you need all the attributions at the top of the file.
4. I'm not sure what an sfx file is... 
5.  We haven't historically distributed built copies of our testing tools, but
I guess if you feel it useful enough we could do such for spinneret.

I think this is a good first start, but this will need some revision before we
can commit this.

More information about the webkit-reviews mailing list