[webkit-reviews] review requested: [Bug 8065] REGRESSION: inline-block elements wrapped in spans lose spaces between them : [Attachment 7510] Patch that fixes the bug

[bugzilla-request-daemon at opendarwin.org]

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 8065: REGRESSION: inline-block elements wrapped in spans lose spaces
between them
http://bugzilla.opendarwin.org/show_bug.cgi?id=8065

Attachment 7510: Patch that fixes the bug
http://bugzilla.opendarwin.org/attachment.cgi?id=7510&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
The bug was in the code that tries to avoid creating RenderTexts if it thinks
they are unnecessary whitespace.  There were two mistakes in the code that
attempted to check for blocks inside inlines.

(1) The parent check just asked if the parent was "inline" and assumed that
meant that it was an inline flow.  This check was incorrectly true for
inline-block parents.

(2) The check for an existing child asked if the child was a RenderBlock.  This
tells you nothing about whether or not the child is inline or not, since
inline-blocks and regular blocks are all RenderBlocks.	In addition it leaves
out block-level replaced elements like images and form controls.