[webkit-reviews] review granted: [Bug 8072] REGRESSION: text fields at connect.apple.com spill out of the containing box : [Attachment 7503] initial patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Apr 4 13:40:07 PDT 2006


Dave Hyatt <hyatt at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 8072: REGRESSION: text fields at connect.apple.com spill out of the
containing box
http://bugzilla.opendarwin.org/show_bug.cgi?id=8072

Attachment 7503: initial patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7503&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You shouldn't need these lines at all:

+    calcBlockMinMaxWidth();
+
+    if(m_maxWidth < m_minWidth) m_maxWidth = m_minWidth;

Other than that, I think this is right, although we probably need more tests of
non-fixed widths on text fields (i.e., width:100%).



More information about the webkit-reviews mailing list