[webkit-reviews] review requested: [Bug 8039] Remove use of DeprecatedArray in favor of new Vector class : [Attachment 7488] patch 3

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Apr 3 12:40:41 PDT 2006


Sam Weinig <sam.weinig at gmail.com> has asked Eric Seidel
<macdome at opendarwin.org> for review:
Bug 8039: Remove use of DeprecatedArray in favor of new Vector class
http://bugzilla.opendarwin.org/show_bug.cgi?id=8039

Attachment 7488: patch 3
http://bugzilla.opendarwin.org/attachment.cgi?id=7488&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
This is quite similar to the previous version with some minor adjustments and a
changelog entry.  Image and friends are still using
DeprecatedArray/DeprecatedByteArray.  Because of this, in CachedImage I had to
copy from a Vector to a DeprecatedByteArray which I am worried is going to
pretty bad performance wise.  However, when the Image classes change to a
Vector based byte buffer, the problem should go away.



More information about the webkit-reviews mailing list