[webkit-reviews] review requested: [Bug 8079] REGRESSION: Redraw from page cache does not show visited links : [Attachment 7476] Patch v1 (no test)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Apr 2 21:53:19 PDT 2006

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 8079: REGRESSION: Redraw from page cache does not show visited links

Attachment 7476: Patch v1 (no test)

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Okay, I found the problem using the debugger.  One line of code (a one-line
'if' statement that really should have been formatted as two lines) was removed
from the end of the reparseConfiguration() method in Frame.cpp from the patch
for Bug 7907:

-  if (d->m_doc) d->m_doc->updateStyleSelector();

Adding this back fixes this bug.  I do not have a test yet.  I think a test
will require an http test with a PNG so that a unique link is rendered as
visited.  I'll need more time to write a test if that is required for this fix
(unless someone else wants to do it).

Also, I did not see a reason for removing this line of code in Bug 7907, so I'm
not sure if adding this back is the appropriate fix.

More information about the webkit-reviews mailing list