[webkit-reviews] review requested: [Bug 8099] REGRESSION: XMLHttpRequest lowercase post requests broken : [Attachment 7458] revised fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Apr 2 06:14:50 PDT 2006

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 8099: REGRESSION: XMLHttpRequest lowercase post requests broken

Attachment 7458: revised fix

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
> Whose job should it be to do this uppercasing? Should this be in TransferJob
> we don't have to do it two different places in XMLHttpRequest?

  "Get" or "put" are valid methods, different from "GET" and "PUT", so
TransferJob probably shouldn't change their case. However, I have now found
that Firefox has more complex logic - it uppercases methods it knows about, and
leaves others untouched. This is a bit weird, but since we are matching their
quirk here, we should probably honor this further complication, too. This new
patch uses a list of headers from Firefox (nsHttpAtomList.h).

> Can m_method be changed into a String instead of a DeprecatedString so that
> can do comparisons on it using equalIgnoringCase instead of constantly
> lower() on it?

  This new patch does comparisons via ==; since there are many other uses of
DeprecatedString in this class, I think that they should rather be all changed
is a separate cleanup patch.

More information about the webkit-reviews mailing list