[webkit-reviews] review granted: [Bug 8099] REGRESSION: XMLHttpRequest lowercase post requests broken : [Attachment 7447] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Apr 1 15:23:06 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8099: REGRESSION: XMLHttpRequest lowercase post requests broken
http://bugzilla.opendarwin.org/show_bug.cgi?id=8099

Attachment 7447: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=7447&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Whose job should it be to do this uppercasing? Should this be in TransferJob so
we don't have to do it two different places in XMLHttpRequest?

Can m_method be changed into a String instead of a DeprecatedString so that we
can do comparisons on it using equalIgnoringCase instead of constantly calling
lower() on it?

Anyway, r=me.



More information about the webkit-reviews mailing list