[webkit-reviews] review requested: [Bug 8032] REGRESSION: Focus ring not completely redrawn after a Delete changes its size : [Attachment 7438] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Apr 1 05:16:34 PST 2006


Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 8032: REGRESSION: Focus ring not completely redrawn after a Delete changes
its size
http://bugzilla.opendarwin.org/show_bug.cgi?id=8032

Attachment 7438: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7438&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
When an element changes size, only part of the element is redrawn. The part
that is redrawn is the difference between the old and the new rectangles taking
into account borders that need to be redrawn. However, this code was not also
taking into account outlines that may need to be redrawn. This patch fixes
this.

The reason that the original testcase attached with this patch could not be
reproduced by adding document.execCommand("Delete"); to the end of the <script>
tag is that the document has not been rendered by this point, and so the
document is rendered only once, and hence correctly.

I modified the testcase (I will attach) uses
setTimeout("document.execCommand('Delete')", 0); to do the work, however,
DumpRenderTree does a pixel dump before the timeout has been reached, and the
test doesn't work in the LayoutTests. I don't know how else to cover this bug
with a layout test.



More information about the webkit-reviews mailing list